New in ISPConfig development and have some questions

Discussion in 'Developers' Forum' started by karailiev, Nov 19, 2008.

  1. karailiev

    karailiev New Member

    Hello all!
    I'm new in the development team and have few questions.
    I've assigned to myself a ticket about password strength indicator and I have it working. It's about 100 lines javascript and I'm wondering where to put it.
    When I add it to interface\web\js\scrigo.js it's working fine, but I want to ask if this is the right place.
    I also have to create new label "Password strength", so I added it to interface\web\client\lib\lang\en_client.lng
    Should I edit other languages' files (de/it/fr/nl) or should I somehow inform the users who maintain them?
     
  2. till

    till Super Moderator Staff Member ISPConfig Developer

    Thats the right place.

    The best might be to add the english version to the other language files as well. But in case that a developer forgtets to add a string to all languages, it is not a problem as the language editor has a feature called "merge" to add missing strings from the english master language file to the other language files.
     
  3. karailiev

    karailiev New Member

    Is there some way to use the translation files in javascript?
    I have strings like "too short", "weak", "strong" and it would be nice to translate them to all available languages.
     
  4. till

    till Super Moderator Staff Member ISPConfig Developer

    Thats not implemented yet. But it should not be a problem to deliver the javascript trough a php file and replace the language strings with the template engine used in ispconfig3.
     
  5. karailiev

    karailiev New Member

    When I see a bug or feature that I can fix/implement should I do it or first have to report it in the bugtracker and wait to be confirmed?
     
  6. till

    till Super Moderator Staff Member ISPConfig Developer

    Please report it in the bugtracker and assign it to yourself. You dont have to wait until it gets confirmed.
     

Share This Page