Issue with dbconfig-common and autocreating databases for roundcube, phpmyadmin

Hi,
following new tutorial installing ISPConfig on Debian Buster, I have a issue while installing roundcube and phpmyadmin/unstable (didn't try manual installation of current packages).
I set up correct root password in debian.cnf, set 'yes' to the question Configure database for roundcube with dbconfig-common?
Installer always ends with: mysql said: ERROR 1049 (42000): Unknown database 'roundcube' (or 'phpmyadmin' etc...)
Tried to create db and user from shell, it is working fine. When running dpkg-reconfigure, it ends with the same error. Here is the output:
---
Determining localhost credentials from /etc/mysql/debian.cnf: succeeded.
dbconfig-common: writing config to /etc/dbconfig-common/roundcube.conf
Replacing config file /etc/dbconfig-common/roundcube.conf with new version
roundcube already exists and has privileges on roundcube.
dbconfig-common: dumping mysql database roundcube to /var/tmp/roundcube.roundcube.2019-07-15-21.06.mysql.GABffs.
dbconfig-common: dropping old mysql database roundcube.
dropping database roundcube: success.
verifying database roundcube was dropped: success.
creating database roundcube: failed.
error encountered creating database:
mysql said: ERROR 1049 (42000): Unknown database 'roundcube'
---
There is no special chars in mariadb root password. Any idea? Thanks

 

Yes I run this command, just with -p parameter at the end to confirm root password - without the parameter it returned Access denied for user 'root'@'localhost' (using password: NO). After that I restarted mariadb service, still no luck...

 

Maybe at the beginning of installation it didn't ask for a password, I am not sure now But I think it asked for a password even on Debian 9 installers I've tried (without dbconfig issues there). The base files are taken from OVH Debian 10 template (server hosted at OVH), but the installed system was clean, without preinstalled and preconfigured packages like mariadb/mysql etc.

 

My guess is this is the reason. Install Debian Buster yourself on an empty host following the Guide. https://www.howtoforge.com/tutorial/debian-minimal-server/

 

Thanks Till, it seems to be working now. I tried yesterday to manually create a database for roundcube from a mysql shell, but dbconfig dropped that database (as you can see from output in first post) - maybe there was a problem I had strong mariadb root password with a special chars.

 

Ok thanks for your help. I can confirm phpmyadmin unstable (from Debian Sid) installed fine too after manually created database.

 

I've tried purge phpmyadmin now and install it again, without manually created database. I can confirm the same error:
mysql said: ERROR 1049 (42000): Unknown database 'phpmyadmin'
So it looks as a bug in dbconfig-common for me too...

 

All together: I further investigated this. It is indeed a bug in dbconfig-common that is VERY easy to fix:

Code:

--- /usr/share/dbconfig-common/internal/mysql.orig    2019-07-31 21:00:12.127398976 +0200
+++ /usr/share/dbconfig-common/internal/mysql    2019-07-31 21:01:06.957160111 +0200
@@ -195,7 +195,8 @@
         if [ "${dbc_mysql_createdb_encoding:-}" ]; then
             extrasql=" CHARACTER SET '$dbc_mysql_createdb_encoding'";
         fi
-        _dbc_nodb="yes" dbc_mysql_exec_command "CREATE DATABASE \`$dbc_dbname\`${extrasql:-}"
+        _dbc_nodb="yes"
+    dbc_mysql_exec_command "CREATE DATABASE \`$dbc_dbname\`${extrasql:-}"
         ret=$?
         _dbc_nodb=""
         if [ "$ret" = "0" ]; then
@@ -314,7 +315,8 @@
 FLUSH PRIVILEGES;
 EOF
         l_dbname=$dbc_dbname
-        _dbc_nodb="yes" dbc_mysql_exec_file "$l_sqlfile"
+        _dbc_nodb="yes"
+    dbc_mysql_exec_file "$l_sqlfile"
         l_ret=$?
         _dbc_nodb=""

Store this in a file called e.g. /tmp/dbconfig-common.patch (or download the one from this thread attachment and upload/rename it).
Then issue:

Code:

$> patch /usr/share/dbconfig-common/internal/mysql /tmp/dbconfig-common.patch

Update: Even more easy:

Code:

sed -i -r 's/_dbc_nodb="yes" dbc_mysql_exec/_dbc_nodb="yes"; dbc_mysql_exec/g' /usr/share/dbconfig-common/internal/mysql

After that you can use the apt-get install roundcube or phpmyadmin without problems.

Short explanation:
It seems that somewhen during the last updates of dbconfig-common there were 2 newlines that got lost. Without those newlines the variable _dbc_nodb is not correctly set inside the function that creates the sql command.
This results in something like this (/tmp/xxx.sql to contain the CREATE DATABASE roundcube):

Code:

mysql --defaults-file=/tmp/xxxx roundcube < /tmp/xxxx.sql

With the _dbc_nodb correctly set, the command would be:

Code:

mysql --defaults-file=/tmp/xxxx < /tmp/xxxx.sql

As the database "roundcube" does not yet exist at that point the first command fails.

 

So the bug is in a file that comes from Debian package dbconfig-common?
Was this fix and report submitted to bugs.debian.org? I tried to find it there but no luck.

 

I am not exactly sure because the file seems not to have changed since lot of months. Maybe it is a combination of dbconfig-common and bash or dash or … don't know. I submitted a merge request here: https://salsa.debian.org/debian/dbconfig-common/merge_requests/2
That solves it.