invalid HTML when create new DNS SPF & DMARC record

Hi all,

When I create a new DNS SPF or DMARC record, there is "/>" next to the "Active" checkbox, after checking the HTML, it is:

HTML:

<input type="checkbox" value="1" id="active" name="active" <input="">
/>

I found that the problem is:
/usr/local/ispconfig/interface/web/dns/dns_spf_edit.php

PHP:

$sql = "SELECT data, active FROM dns_rr WHERE data LIKE 'v=spf1%' AND zone = ? AND " . $app->tform->getAuthSQL('r');

/usr/local/ispconfig/interface/web/dns/dns_dmarc_edit.php

PHP:

$sql = "SELECT data, active FROM dns_rr WHERE data LIKE 'v=DMARC1%' AND zone = ? AND name = ? AND " . $app->tform->getAuthSQL('r');

And then this condition always return false

PHP:

if ( isset($rec) && !empty($rec) )

so that it cannot assign CHECKED or UNCHECKED.

PHP:

if ($rec['active'] == 'Y') $app->tpl->setVar("active", "CHECKED"); else $app->tpl->setVar("active", "UNCHECKED");

If it assigns CHECKED or UNCHECKED at the beginning of function onShowEnd(), then problem solved, but I am not sure if it is good idea to do this.

ISPConfig version: 3.1.14

Please advice & fix.

 

push

 

https://git.ispconfig.org/ispconfig/ispconfig3/issues/5359
Thank you.