BUG in Patches for 3.0.5.3

Discussion in 'Developers' Forum' started by suther, Oct 23, 2013.

  1. suther

    suther Member

    I got this output for diffenert Patches of 3.0.5.3:

     
  2. till

    till Super Moderator Staff Member ISPConfig Developer

    Thats a config problem on your server and not related to the patches. Edit the file /etc/php5/cli/conf.d/ming.ini and replace the leading # with ;
     
  3. suther

    suther Member

    Thanks a lot. Solved.
     
  4. onastvar

    onastvar Member

    I have same issue. I do not have the file /etc/php5/cli/conf.d/ming.ini, any ideas how to fix?

    HTML:
    Enter patch id: 3053_backupdownload
    
    Patch description:
    --------------------------------------------------------------------------------
    This patch fixes an issue with downloading and restoring website backups.
    --------------------------------------------------------------------------------
    Do you really want to apply this patch now? (y,n) [y]: y
    
    (Stripping trailing CRs from patch.)
    patching file interface/lib/classes/plugin_backuplist.inc.php
    Hunk #1 FAILED at 57.
    1 out of 1 hunk FAILED -- saving rejects to file interface/lib/classes/plugin_backuplist.inc.php.rej
     
  5. ispcomm

    ispcomm Member

    the ming.ini file is broken on all squeeze installations upgraded to wheezy.
    I'm not sure about native wheezy tough.
    I had to edit manually that file on many servers.
     
  6. onastvar

    onastvar Member

    My server was a Squeeze installation which was upgraded to Wheezy. Could you post content of /etc/php5/cli/conf.d/ming.ini ?
     
  7. orasis

    orasis Member

    even on Wheezy this file still has # instead of ; and one has to manually change it.

    the contents are
    Code:
    ; configuration for php MING module
    extension=ming.so
    
     
  8. onastvar

    onastvar Member

    I'm still getting error when I try to apply patch 3053_backupdownload


    >> Patch tool

    Please enter the patch id that you want to be applied to your ISPConfig installation.
    Please be aware that we take NO responsibility that this will work for you.
    Only use patches if you know what you are doing.

    Enter patch id: 3053_backupdownload

    Patch description:
    --------------------------------------------------------------------------------
    This patch fixes an issue with downloading and restoring website backups.
    --------------------------------------------------------------------------------
    Do you really want to apply this patch now? (y,n) [y]: y

    (Stripping trailing CRs from patch.)
    patching file interface/lib/classes/plugin_backuplist.inc.php
    Hunk #1 FAILED at 57.
    1 out of 1 hunk FAILED -- saving rejects to file interface/lib/classes/plugin_backuplist.inc.php.rej


    here's content of my file "plugin_backuplist.inc.php.rej"


    Code:
    --- interface/lib/classes/plugin_backuplist.inc.php     (Revision 4136)
    +++ interface/lib/classes/plugin_backuplist.inc.php     (Revision 4139)
    @@ -57,7 +57,12 @@
    
                                            //* check if the user is  owner of the parent domain
                                            $domain_backup = $app->db->queryOneRecord("SELECT parent_domain_id FROM web_backup WHERE backup_id = ".$backup_id);
    -                                       if(!$app->tform->checkOwnerPermisssions($this->dataRecord["parent_domain_id"])){
    +
    +                    $check_perm = 'u';
    +                    if($_GET['backup_action'] == 'download') $check_perm = 'r'; // only check read permissions on download, not update permissions
    +
    +                                       $get_domain = $app->db->queryOneRecord("SELECT domain_id FROM web_domain WHERE domain_id = ".$app->functions->intval($domain_backup["parent_domain_id"])." AND ".$app->tform->getAuthSQL($check_perm));
    +                                       if(empty($get_domain) || !$get_domain) {
                                                    $app->error($app->tform->lng('no_domain_perm'));
                                            }
    
     
  9. orasis

    orasis Member

    usually when a hunk fails is when you are attempting to patch a wrong version ? You also said previously that the file /etc/php5/cli/conf.d/ming.ini was missing from your system ?
     
  10. onastvar

    onastvar Member

    Thanks!
    I have the file in this folder /etc/php5/cli/conf.d/ming.ini
    still get Hunk #1 FAILED at 57.
     
  11. orasis

    orasis Member

    I have patched my old installation fine although I haven't applied any patches on this one I installed today so I am not sure what the specific patch would do on my system.

    One of the developers can give you the best answer on this. But it sounded weird that your system was missing the file /etc/php5/cli/conf.d/ming.ini as you said in a previous reply.
     

Share This Page