Hi, quick thought regarding the E-Mail Domain and E-Mail Routing feature: I currently manage quite a few "E-Mail Routing" transport rules to relay mail to our exchange servers for customers. When I log in with a customers credentials, I cant see their E-Mail Routing settings, which is fine. However, I do have a slight concern: what if a customer adds their domain under "E-Mail Domain" because they assume it should be there? This could potentially break the existing transport rules. Would it make sense to implement a check within the interfaces create functions? For instance, if someone tries to create an "E-Mail Domain" but there is already an existing "E-Mail Routing" entry (or vice versa), there could be shown a warning about the potential conflict. Any thoughts?
Yes, we should add such a check. The other way round too (adding a transport when there is already a email domain).
So would the approach to extend the validate_mail_transport.inc.php for both functions be the preferred one? Or do you think we should separate them allthough i can't seem to find a validate_ for mail_domain or mail itself?
Maybe we should add the transport validation in validate_mail_transport.inc.php and add a similar new file for mail domain, just to keep things tidy and organized. If you look up such things in a few years, you would likely not expect to find the mail domain validation in the transport file, so we better make a new file for the mail domain check.
Understood. I've already created the issue: https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6791 and working on a fix right now. Thank you for the input
It took some time, but the merge request has been created. There are two points that need discussion, but I’m confident we’ll resolve them soon. The details are in a comment of the MR.
