Error at spam policy page.

Yes, there is an issue indeed. The cutoff level fields may not be empty, they must contain a number like 0 or 0.00

 

FWIW, the default schema creates spamfilter_policy's with NULL in spam_dsn_cutoff_level, so simply editing one of those will trigger this error on a clean install:

Code:

MariaDB [dbispconfig]> select id, policy_name, spam_dsn_cutoff_level from spamfilter_policy;
+----+----------------+-----------------------+
| id | policy_name    | spam_dsn_cutoff_level |
+----+----------------+-----------------------+
|  1 | Non-paying     |                  0.00 |
|  2 | Uncensored     |                  NULL |
|  3 | Wants all spam |                  NULL |
|  4 | Wants viruses  |                  NULL |
|  5 | Normal         |                  0.00 |
|  6 | Trigger happy  |                  NULL |
|  7 | Permissive     |                  NULL |
+----+----------------+-----------------------+
7 rows in set (0.001 sec)

 

Ok, so we should adjust the ispconfig3.sql file for 3.2.

 

Or allow an empty value in the ui, as in a little research it appears to be valid if the cutoff levels are unset (which is confirmed by use of any of those policies).

 

Also an update in incremental file. Changing the schema to not null, and default of 0.00 should update all existing policies (if that's a better solution than allowing them to remain unset).

 

We have to keep in mind that a lot of users delete the default policy's, not sure if a error would cause issues.