Problem with web backup download

Discussion in 'General' started by mikolaj_koziej, Jan 12, 2022.

  1. mikolaj_koziej

    mikolaj_koziej New Member

    Helo
    Has the download of web copies changed in the new version?
    I have installed a second ispconfig (multiservers) web server.
    I want to download a backup and can't.
    1. Backup files there are information in the database as well.
    2. Cron starts: "Calling function 'backup_action' from plugin 'backup_plugin' raised by action 'backup_download'."
    3. The backup is not copied to /var/www/xxxx.com/backup/
    4. I checked and all pages on the new server do not have directories: /var/www/*/backup/
    5. Condition in /usr/local/ispconfig/server/plugins-available/backup_plugin.inc.php:91 :
    "file_exists($backup_dir.'/'.$backup['filename']) && file_exists($web['document_root'].'/backup/') && !stristr($backup_dir.'/'.$backup['filename'], '..') && !stristr($backup_dir.'/'.$backup['filename'], 'etc')" returns false, because "file_exists ($ web ['document_root']. '/backup/')" is false
    6. The copy cannot be downloaded

    I installed the latest version of ispconfig.
    I create clients and websites via webpanel and API. It is the same in both cases
     
  2. Th0m

    Th0m ISPConfig Developer Staff Member ISPConfig Developer

  3. till

    till Super Moderator Staff Member ISPConfig Developer

    Maybe there are special conditions in which no backup folder gets added?
     
  4. Jesse Norell

    Jesse Norell Well-Known Member Staff Member Howtoforge Staff

    Looks like the directory is created in backup::backups_garbage_collection(), which is called from run_all_backups() and also from make_database_backup(), but not from make_web_backup() - so if you manually ran a web backup, it would not get created (at least not until the next run_all_backups(), assuming the site is set for a scheduled backup).
     
  5. Jesse Norell

    Jesse Norell Well-Known Member Staff Member Howtoforge Staff

  6. Th0m

    Th0m ISPConfig Developer Staff Member ISPConfig Developer

    Seems like this is not the problem, as
    PHP:
    self::prepare_backup_dir($server_id$web_domain);
    is called in the make_web_backup function.

    Can anyone else reproduce the issue?
     
  7. Th0m

    Th0m ISPConfig Developer Staff Member ISPConfig Developer

    Last edited: Feb 26, 2022
    ahrasis, Jesse Norell and till like this.
  8. Jesse Norell

    Jesse Norell Well-Known Member Staff Member Howtoforge Staff

    Or maybe when a backup is retrieved for download or restore.
     
  9. Th0m

    Th0m ISPConfig Developer Staff Member ISPConfig Developer

    As it is created at night anyway (if not exists), I just added it to the to be created folders on web creation.
     

Share This Page