Recursive backup

Hi all!

Just thought I might share a feature that I ran across. Might be something htat should be fixed in next release.
One of my users added a symlink to his website to make http://domain.com/funnypath/ point back to http://domain.com/. This was done with a symlink, i.e. /home/www/webXX/web/funnypath -> /home/www/webXX/web/.
This causes the backup script to recurse and create a huge backup file filling the quota for the user.

In the backup script /root/ispconfig/scripts/shell/backup.php I changed
exec("cd $web_pfad; $zip -r $tmp_dir/web".$web_id."_web.zip *");
to
exec("cd $web_pfad; $zip -ry $tmp_dir/web".$web_id."_web.zip *");

That is -ry and not only -r as a switch for zip. This prevents zip from following symlinks and going recursive on me

Is there any reason why this would be a bad thing to do?

//Erk

 

Thanks for the hint, we will fix this.

 

Great! Might want to add that -ry to the other zip commands in the backup script aswell. Just to be on the safe side. Symlinks can be a pain if you start to follow them...

//Erk