SVN: web backups

I'm looking at the latest SVN trunk.
How can web backup works in a multi server setups?
The client doesn't have write access to sys_datalog and web_backup tables so the following query will always fail:

Code:

//* Insert web backup record in database
$insert_data = "(server_id,parent_domain_id,backup_type,backup_mode,tstamp,filename) VALUES (".$conf['server_id'].",".$web_id.",'web','".$backup_mode."',".time().",'".$app->db->quote($web_backup_file)."')";
$app->dbmaster->datalogInsert('web_backup', $insert_data, 'backup_id');

 

cron_daily.php

 

I've added SELECT,INSERT,DELETE grants to web_backup table, but I don't see any grant for sys_datalog.

Is sys_datalog supposed to be different between master and client ?
Actually, backup entries are stored on the client only.

 

Ok, but sys_datalog can be different between master and client ?
The actual cron will write only to the client, seems to work because i'm able to see the backup list from the interface, but on the master there is no reference to these backups.

I don't know why master should have the client backup list, maybe that the actual script is good as it is.

 

Ok, in this case, the backup script is working properly because the client calls

Code:

$app->dbmaster->datalogInsert('web_backup', $insert_data, 'backup_id');

datalogInsert will do the insert and then calls datalogSave that will write on "db" and not on "dbmaster".

In this way, the backup item is wrote properly on sys_datalog on the client and never on the master.

If this is correct, cron script is working properly.

 

did you changed only the datalogSave function?

 

sys_datalog on master is still not updated by client's cron.

 

With SVN changes, even the insert on web_backup on master doesn't work anymore. Our permissions are correct.

 

The same broken query apply on mail stats calculation.
From your daily_cron.php, you are calculating mail traffic saving data to the master db:

($size is one on mine customization, there is no $size in SVN code)


Now, from the interface code (mail_user_stats.php), you are quering the local server and not the master:

Code:

	function prepareDataRow($rec)
    {
		global $app;
		
		$rec = $app->listform->decode($rec);

		//* Alternating datarow colors
		$this->DataRowColor = ($this->DataRowColor == '#FFFFFF') ? '#EEEEEE' : '#FFFFFF';
		$rec['bgcolor'] = $this->DataRowColor;
		
		//* Set the statistics colums
		//** Traffic of the current month
		$tmp_date = date('Y-m');
		$tmp_rec = $app->db->queryOneRecord("SELECT traffic as t FROM mail_traffic WHERE mailuser_id = ".$rec['mailuser_id']." AND month = '$tmp_date'");
		$rec['this_month'] = number_format(intval($tmp_rec['t'])/1024/1024, 0, '.', ' ');
		
		//** Traffic of the current year
		$tmp_date = date('Y');
		$tmp_rec = [B]$app->db->queryOneRecord[/B]("SELECT sum(traffic) as t FROM mail_traffic WHERE mailuser_id = ".$rec['mailuser_id']." AND month like '$tmp_date%'");
		$rec['this_year'] = number_format(intval($tmp_rec['t'])/1024/1024, 0, '.', ' ');
		

 

News about this?

 

What I still don't understand is:

- is ISPConfiged engineered to have different datas between master and client databases? Actually, some data (mostly coming from crontab) are saved only on master, this will make an inconsistency on the slave itself.

Is this ok?

For example, mail usage statistics are generated by slave crontab and saved on master DB. This will make a different mail_traffic table between master and slave. The slave will be always empty. Is this ok?