Upgrade to ISPConfig 3.1 no backup

I'm working on mount/unmount scripts (using sshfs + fuse, I'll post them when ready) and they work fine from cli, but I find the backup mount point is not getting unmounted, at least after clicking "Download" to download a client's backup. The mount is working correctly, and the backup file is copied to the right spot for the client, just the unmount doesn't happen - is this something I have in my environment, or is that a bug? Also, does it get unmounted after creating backups each night? (I had the unmount script misnamed last night, but it's correct now, so I should know tomorrow.)

 

After further testing I created https://git.ispconfig.org/ispconfig/ispconfig3/issues/4346

For the curious, the unmount does happen when nightly backups are created.

 

If useful to anyone, here's a mount/unmount script that uses sshfs + encfs, and optionally stores the encryption passphrase on a mandos server. Easy to adapt to CryFS if you don't like encfs.

/usr/local/ispconfig/server/scripts/backup_dir_mount.sh:

Code:

#!/bin/bash

# backup_dir_mount.sh - called by ispconfig
# to mount the backup directory prior to backing up
#
# This uses sshfs + encfs + mandos
# to securely mount a remote server (sshfs),
# and encrypt the remote data (encfs).
# We store the encryption key on the mandos server.

# Final desination where backups will be made, files within it are unencrypted:
BACKUP_DIR=/var/ispc_backup_mnt

# This file must exist once encfs filesystem is fully accessible
CHECK_FILE="${BACKUP_DIR}/README.failsafe"

# We sshfs mount this directory, and files within it are encrypted:
SSHFS_MNT_DIR=/var/.ispc_backup_sshfs_mnt

# Remote user/server and directory to mount
SSH_USER="[email protected]"
SSHFS_DIR="/mnt/ispconfig_client_backups/`hostname -s`"
SSHFS_SOURCE="${SSH_USER}:${SSHFS_DIR}"

# Encryption key or 'mandos' to call mandos-client
KEY=mandos

# path to mandos-client
MANDOS_CLIENT=
MANDOS_TIMEOUT=60
PUBKEY=/etc/keys/mandos/pubkey.txt
SECKEY=/etc/keys/mandos/seckey.txt

function die() {
    echo "${@}" 1>&2
    exit 1
}

if [ ! -d "${SSHFS_MNT_DIR}" ]
then
    mkdir -m 770 -p "${SSHFS_MNT_DIR}" || die "Unable to create sshfs mount dir ${SSHFS_MNT_DIR}"
fi

test -d "${SSHFS_MNT_DIR}" || die "Directory does not exist: ${SSHFS_MNT_DIR}"
test -d "${BACKUP_DIR}" || die "Directory does not exist: ${BACKUP_DIR}"

ssh ${SSH_USER} test -d ${SSHFS_DIR}
if [ $? -ne 0 ]
then
    echo "Error: Remote directory does not exist.  Try creating it with:

    ssh ${SSH_USER} mkdir -p ${SSHFS_DIR}
"
    die
fi

which sshfs > /dev/null || die "sshfs: command not found"
which encfs > /dev/null || die "encfs: command not found"

if [ "${KEY}" == "mandos" ]
then
    if [ -z "${MANDOS_CLIENT}" ] || [ ! -f "${MANDOS_CLIENT}" ]; then
      MANDOS_CLIENT=$(which mandos-client /usr/lib/{,*/}mandos/plugins.d/mandos-client | head -1)
      if [ ! -f "${MANDOS_CLIENT}" ]; then
        die "mandos-client not found"
      fi
    fi

    test -f "${PUBKEY}" || die "Error: pubkey (${PUBKEY}) not found.  Need to run mandos-keygen?"
    test -f "${SECKEY}" || die "Error: seckey (${SECKEY}) not found.  Need to run mandos-keygen?"

    KEY=$(timeout ${MANDOS_TIMEOUT} ${MANDOS_CLIENT} --pubkey=${PUBKEY} --seckey=${SECKEY})
fi

test -z "${KEY}" && die "Could not obtain encryption key"

if [ ! -f "${SSHFS_MNT_DIR}/.encfs6.xml" ]
then
    # sshfs mount remote server
    sshfs -o uid=0,gid=0,nosuid,nodev ${SSHFS_SOURCE} ${SSHFS_MNT_DIR} || die "Error: sshfs mount failed"
fi

if [ ! -f "${SSHFS_MNT_DIR}/.encfs6.xml" ]
then
    echo "EncFS does not appear to be created on the remotely mounted directory." 1>&2
    echo "First create it with:  encfs -o allow_other ${SSHFS_MNT_DIR} ${BACKUP_DIR}" 1>&2
    echo "Then unmount and try again:  fusermount -u ${BACKUP_DIR}; fusermount -u ${SSHFS_MNT_DIR}" 1>&2
    die
fi

if [ ! -f "${CHECK_FILE}" ]
then
    # encfs mount remote mount
    encfs --stdinpass -o nonempty,nosuid,nodev ${SSHFS_MNT_DIR} ${BACKUP_DIR}  <<< "${KEY}" || die "Error: encfs mount failed"
fi

test -f "${CHECK_FILE}" || die "Error: failsafe check file not found (${CHECK_FILE})"

exit 0

/usr/local/ispconfig/server/scripts/backup_dir_umount.sh:

Code:

#!/bin/bash

# backup_dir_unmount.sh - called by ispconfig
# to unmount the backup directory after backing up
#
# The mount uses sshfs + encfs + mandos
# to securely mount a remote server (sshfs),
# and encrypt the remote data (encfs).
# As such, the unmount is a simple fusermount -u

# Final desination where backups will be made, files within it are unencrypted:
BACKUP_DIR=/var/ispc_backup_mnt

# This file must exist once encfs filesystem is fully accessible
CHECK_FILE="${BACKUP_DIR}/README.failsafe"

# We sshfs mount this directory, and files within it are encrypted:
SSHFS_MNT_DIR=/var/.ispc_backup_sshfs_mnt

function die() {
    echo "${@}" 1>&2
    exit 1
}

test -d "${BACKUP_DIR}" || die "Directory does not exist: ${BACKUP_DIR}"
test -d "${SSHFS_MNT_DIR}" || die "Directory does not exist: ${SSHFS_MNT_DIR}"

test -f "${CHECK_FILE}" || die "Error: encfs appears to be not mounted, failsafe check file not found (${CHECK_FILE})"
test -f "${CHECK_FILE}" && (fusermount -u "${BACKUP_DIR}" || die "encfs fusermount unmount failed")
test -f "${CHECK_FILE}" && die "Error: encfs fusermount unmount appears to have failed"

test -f "${SSHFS_MNT_DIR}/.encfs6.xml" && (fusermount -u "${SSHFS_MNT_DIR}" || die "sshfs fusermount unmount failed")
test -f "${SSHFS_MNT_DIR}/.encfs6.xml" && die "Error: sshfs fusermount unmount appears to have failed"

exit 0

Make those both executable, and remember to edit the Server Config to set the backup directory (and/or change the scripts to match) and enable 'Backup directory is a mount?' checkbox.