Whitelist/Blacklist

Discussion in 'Feature Requests' started by joostvdl, Mar 2, 2006.

  1. joostvdl

    joostvdl Member

    Hello

    Can the whitelist/blacklist from spamassin be managed from ispconfig.

    I have edited via the filesystem .user_prefs file. But this file is overwritten after the last update.
     
  2. falko

    falko Super Moderator ISPConfig Developer

    No, that's not possible.
     
  3. joostvdl

    joostvdl Member

    I posted it in feature requests. But I don't know if you answer definitly meens dat the whitelist can't be added in future releases
    OR
    that it isn't available now?
     
  4. falko

    falko Super Moderator ISPConfig Developer

    It isn't available right now, but might be in a future version. :)
     
  5. joostvdl

    joostvdl Member

    Yippie

    :)
     
  6. wriley

    wriley New Member

    I made a quick set of patches to support whitelist/blacklist. It is far from perfect but it works for me and you are welcome to use it/improve it.

    Screenshot and patches on my blog.
     
  7. todvard

    todvard ISPConfig Developer ISPConfig Developer

    hmm, this is a nice patch.

    Till, Falko, are you planning to merge this patch or something else with similar funtionalities?

    Cheers,
    Tod.
     
  8. falko

    falko Super Moderator ISPConfig Developer

    If we find enough time... :D
     
  9. todvard

    todvard ISPConfig Developer ISPConfig Developer

    it would be nice :)
    i am afraid to apply this patch as it needs to change tha structure of the isp_isp_user table, and i want to keep the ipsconfig database clean from third party changes. i don't want problems at upgrade time thats why i am asking :)
     
  10. falko

    falko Super Moderator ISPConfig Developer

    That's a wise decision. :)
     
  11. till

    till Super Moderator Staff Member ISPConfig Developer

    I just had a look at the patch. It seems that this patch is only for the mailuser interface but it did not add the functionality to the email forms that where used by the admin, resellers or customers.

    If one of the ISPConfig developers or the author has the time to implement the missing interface parts for admin, resellers or customers we can merge it in the ISPConfig dev tree.
     
  12. wriley

    wriley New Member

    Oops, I forgot the database patch! For those interested, something like this SQL code should work:
    Code:
    ALTER TABLE `isp_isp_user` ADD `spam_wlist` TEXT AFTER `spam_hits`;
    ALTER TABLE `isp_isp_user` ADD `spam_blist` TEXT AFTER `spam_wlist`;
     
  13. wriley

    wriley New Member

    I played around with the form editor tonight. I didn't realize it would create columns in the database, so I backed out my two columns (spam_wlist,spam_blist) and added them (the right way) using the form editor. The exported form is attached, you might have to remove the .txt extension. Import it and tell it to update existing form. BEWARE THIS COULD BREAK YOUR ISPCONFIG INSTALL!!!

    I added a 3rd patch for the en.lng file that I forgot to include.
    Code:
    --- /home/admispconfig/ispconfig/web/mailuser/lib/lang/en.lng.orig      2006-05-17 00:38:07.000000000 -0400
    +++ /home/admispconfig/ispconfig/web/mailuser/lib/lang/en.lng   2006-05-13 20:32:26.000000000 -0400
    @@ -17,6 +17,8 @@ $wb["txt_mailscan"] = "MailScan";
     $wb["txt_antivirus"] = "Antivirus";
     $wb["txt_spam_strategie"] = "Spam Strategy";
     $wb["txt_spam_hits"] = "Spam Hits";
    +$wb["txt_spam_wlist"] = "Spam Whitelist";
    +$wb["txt_spam_blist"] = "Spam Blacklist";
     $wb["txt_rewrite_subject"] = "Rewrite Subject";
     $wb["txt_betreff"] = "Subject";
     $wb["txt_name"] = "Name";
    
    -William

    Update: The import form doesn't always work on my system, you may have to manually add the fields to the form.
     

    Attached Files:

    Last edited: May 17, 2006

Share This Page